Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail fast when unrecognized argument is seen #95

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fail fast when unrecognized argument is seen #95

merged 1 commit into from
Oct 23, 2023

Conversation

yfarjoun
Copy link
Contributor

@yfarjoun yfarjoun commented Jul 16, 2023 •
edited
Loading

  • If getopt_long returns a "?" this means that the option parsing failed. Modified the code to look for the '?' and gracefully fail if that happens.

fixes #89

@yfarjoun yfarjoun force-pushed the yf_fix_return_1_on_unrecognized_arg branch from 2419154 to ba7f25e Compare July 16, 2023 04:02
@yfarjoun
Copy link
Contributor Author

Note that #69 adds two CLPs that will also need the '?' treatment....so if it gets merged first, this PR should be amended, and if this gets merged first, it should be amended.

@Yenaled
Copy link
Collaborator

Yenaled commented Jul 17, 2023

Got it, thanks!

@Yenaled Yenaled changed the base branch from master to devel October 23, 2023 02:39
@Yenaled Yenaled merged commit ee15aa0 into BUStools:devel Oct 23, 2023
@yfarjoun yfarjoun mentioned this pull request Oct 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Providing an unrecognized option should result in an error (but doesn't)
2 participants
@yfarjoun @Yenaled